Conversation
|
This change is |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## lifted #1287 +/- ##
=======================================
Coverage 91.97% 91.97%
=======================================
Files 119 119
Lines 14958 14958
Branches 14958 14958
=======================================
Hits 13757 13757
Misses 1111 1111
Partials 90 90 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gali-StarkWare
left a comment
Gali-StarkWare
left a comment
There was a problem hiding this comment.
You can modify this PR to have only the lifted changes
@Gali-StarkWare made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
leo-starkware
left a comment
leo-starkware
left a comment
There was a problem hiding this comment.
Right, I will rebase lifted on dev after merging the pr on dev.
@leo-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
leo-starkware
force-pushed
the
lifted
branch
from
8c41adb to
0d033e1
Compare
leo-starkware
force-pushed
the
leo/fix_nonparallel
branch
from
cdc2ac7 to
47186dd
Compare
leo-starkware
left a comment
leo-starkware
left a comment
There was a problem hiding this comment.
Done
@leo-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, all discussions resolved.
Gali-StarkWare
left a comment
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare reviewed 3 files and all commit messages, and made 2 comments.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @leo-starkware).
crates/stwo/src/prover/backend/simd/quotients.rs line 150 at r2 (raw file):
#[cfg(not(feature = "parallel"))] let iter = domain_points;
Didn't work with .iter()? Interesting
Code quote:
let iter = domain_points;![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 2.
| Benchmark suite | Current: 47186dd | Previous: cdc2ac7 | Ratio |
|---|---|---|---|
simd barycentric_eval_at_secure_field_point 2^20 |
1005287 ns/iter (± 56147) |
414479 ns/iter (± 8280) |
2.43 |
This comment was automatically generated by workflow using github-action-benchmark.
* Add lifted Merkle verifier. (#1234) * Add SIMD MerkleOpsLifted. (#1235) * Add auxiliary structs to vcs_lifted. (#1247) * Add generic blake for lifted vcs. (#1252) * Change queries from vec to slice. (#1250) * Add lift_and_accumulate. (#1245) * Modify finalize of DomainEvaluationAccumulator. (#1246) * Add skeleton of lifted quotient ops. (#1248) All the code related to the previous architecture of quotient ops has been removed. * Add empty poseidon merkle hasher lifted. (#1253) * Change channel's assoc type to MerkleHasherLifted. (#1254) * Add CPU QuotientOps impl. (#1249) * Make pcs prove lifted values. (#1251) * Add pcs verifier lifted. (#1255) * Modify trace step in masks and eval at point. (#1257) * Add CpuBackend impl to ComponentProver. (#1258) * Add mixed wide fibonacci test. (#1259) * Add m31 blake hasher to simd. (#1260) * Allow small traces with cpu, fix bug. (#1261) * Add lift and accumulate in simd. (#1262) * Add simd impl of accumulate_numerators. (#1263) * Add `compute_quotients_and_combine`. (#1266) * Change fri decommit to return a vec of query positions. (#1269) * Commit to a single column in fri. (#1270) * Update docs and rename. (#1271) * Remove iterations in fri verifier decommit. (#1272) * Remove unneeded structure. (#1273) * Update docs. (#1274) * Add poseidon hasher. (#1283) * Add SIMD implementation of poseidon MerkleOpsLifted. (#1280) * Adapt the queries for the preprocessed trees. (#1281) Co-authored-by: Alon F <alonf@starkware.co> * Fix non-parallel bugs. (#1287) * Adapt barycentric weights to the lifted protocol. (#1288) * Change order of the alphas to the samples order. (#1292) * Change queried values layout. (#1293) * Add periodicity samples. (#1294) * Improve performance of cpu merkle. (#1284) * Fix lifting size in fri_answers and add test. (#1296) * Optimize blake simd merkle lifted. (#1291) * Add maximal size periodicity checks. (#1301) * Add dummy serde and reexport MerkleHasherLifted. (#1297) These changes make it easier to integrate with stwo_cairo_prover. --------- Co-authored-by: Alon F <alonf@starkware.co>
4 participants
No description provided.